Add a button to view full error logs. Allow longer than 2000 characters.
Andrew Cantino
4 измененных файлов с 26 добавлено и 3 удалено
+ 21
- 0
app/assets/javascripts/pages/agent-show-page.js.coffee
@@ -15,6 +15,27 @@ class @AgentShowPage |
||
| 15 | 15 |
$("#logs .refresh, #logs .clear").hide()
|
| 16 | 16 |
$.get "/agents/#{agentId}/logs", (html) =>
|
| 17 | 17 |
$("#logs .logs").html html
|
| 18 |
+ $("#logs .logs .show-log-details").each ->
|
|
| 19 |
+ $button = $(this) |
|
| 20 |
+ $button.on 'click', (e) -> |
|
| 21 |
+ e.preventDefault() |
|
| 22 |
+ $("body").append """
|
|
| 23 |
+ <div class="modal fade" tabindex="-1" id='dynamic-modal' role="dialog" aria-labelledby="dynamic-modal-label" aria-hidden="true"> |
|
| 24 |
+ <div class="modal-dialog"> |
|
| 25 |
+ <div class="modal-content"> |
|
| 26 |
+ <div class="modal-header"> |
|
| 27 |
+ <button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button> |
|
| 28 |
+ <h4 class="modal-title" id="dynamic-modal-label"></h4> |
|
| 29 |
+ </div> |
|
| 30 |
+ <div class="modal-body"><pre></pre></div> |
|
| 31 |
+ </div> |
|
| 32 |
+ </div> |
|
| 33 |
+ </div> |
|
| 34 |
+ """ |
|
| 35 |
+ $('#dynamic-modal').find('.modal-title').text $button.data('modal-title')
|
|
| 36 |
+ $('#dynamic-modal').find('.modal-body pre').text $button.data('modal-content')
|
|
| 37 |
+ $('#dynamic-modal').modal('show').on 'hidden.bs.modal', -> $('#dynamic-modal').remove()
|
|
| 38 |
+ |
|
| 18 | 39 |
$("#logs .spinner").stop(true, true).fadeOut ->
|
| 19 | 40 |
$("#logs .refresh, #logs .clear").show()
|
| 20 | 41 |
|
+ 1
- 1
app/models/agent_log.rb
@@ -32,6 +32,6 @@ class AgentLog < ActiveRecord::Base |
||
| 32 | 32 |
protected |
| 33 | 33 |
|
| 34 | 34 |
def truncate_message |
| 35 |
- self.message = message[0...2048] if message.present? |
|
| 35 |
+ self.message = message[0...10_000] if message.present? |
|
| 36 | 36 |
end |
| 37 | 37 |
end |
+ 2
- 0
app/views/logs/index.html.erb
@@ -24,6 +24,8 @@ |
||
| 24 | 24 |
<% else %> |
| 25 | 25 |
<%= link_to 'Event Out', '#', class: "btn btn-default disabled" %> |
| 26 | 26 |
<% end %> |
| 27 |
+ |
|
| 28 |
+ <%= link_to 'Details', '#', :class => "btn btn-default show-log-details", :data => { :'modal-title' => log.level >= 4 ? 'Error' : 'Info', :'modal-content' => log.message } %>
|
|
| 27 | 29 |
</div> |
| 28 | 30 |
</td> |
| 29 | 31 |
</tr> |
+ 2
- 2
spec/models/agent_log_spec.rb
@@ -44,9 +44,9 @@ describe AgentLog do |
||
| 44 | 44 |
|
| 45 | 45 |
it "truncates message to a reasonable length" do |
| 46 | 46 |
log = AgentLog.new(:agent => agents(:jane_website_agent), :level => 3) |
| 47 |
- log.message = "a" * 3000 |
|
| 47 |
+ log.message = "a" * 11_000 |
|
| 48 | 48 |
log.save! |
| 49 |
- expect(log.message.length).to eq(2048) |
|
| 49 |
+ expect(log.message.length).to eq(10_000) |
|
| 50 | 50 |
end |
| 51 | 51 |
|
| 52 | 52 |
describe "#log_for_agent" do |