Removes unnecessary screenshot helper
Switches timeout based on being on slow CI, or fast dev boxes
- can use Capybara's built in `save_and_open_screenshot`
Will Read
共有 4 個文件被更改，包括 4 次插入 和 18 次删除
+ 0
- 1
Gemfile
@@ -144,7 +144,6 @@ group :development do |
||
| 144 | 144 |
gem 'coveralls', require: false |
| 145 | 145 |
gem 'capybara-select2', require: false |
| 146 | 146 |
gem 'delorean' |
| 147 |
- gem 'launchy', require: false |
|
| 148 | 147 |
gem 'poltergeist' |
| 149 | 148 |
gem 'pry-rails' |
| 150 | 149 |
gem 'rr' |
+ 0
- 1
Gemfile.lock
@@ -627,7 +627,6 @@ DEPENDENCIES |
||
| 627 | 627 |
jsonpath (~> 0.5.6) |
| 628 | 628 |
kaminari (~> 0.16.1) |
| 629 | 629 |
kramdown (~> 1.3.3) |
| 630 |
- launchy |
|
| 631 | 630 |
letter_opener_web |
| 632 | 631 |
liquid (~> 3.0.3) |
| 633 | 632 |
listen (~> 3.0.5) |
+ 4
- 4
spec/capybara_helper.rb
@@ -2,18 +2,18 @@ require 'rails_helper' |
||
| 2 | 2 |
require 'capybara/rails' |
| 3 | 3 |
require 'capybara/poltergeist' |
| 4 | 4 |
require 'capybara-select2' |
| 5 |
-require 'helpers/capybara_poltergeist_screenshot' |
|
| 5 |
+ |
|
| 6 |
+CAPYBARA_TIMEOUT = ENV['CI'] == 'true' ? 60 : 5 |
|
| 6 | 7 |
|
| 7 | 8 |
Capybara.register_driver :poltergeist do |app| |
| 8 |
- Capybara::Poltergeist::Driver.new(app, timeout: 5) |
|
| 9 |
+ Capybara::Poltergeist::Driver.new(app, timeout: CAPYBARA_TIMEOUT) |
|
| 9 | 10 |
end |
| 10 | 11 |
|
| 11 | 12 |
Capybara.javascript_driver = :poltergeist |
| 12 |
-Capybara.default_max_wait_time = 5 |
|
| 13 |
+Capybara.default_max_wait_time = CAPYBARA_TIMEOUT |
|
| 13 | 14 |
|
| 14 | 15 |
RSpec.configure do |config| |
| 15 | 16 |
config.include Warden::Test::Helpers |
| 16 |
- config.include Capybara::PoltergeistScreenshot |
|
| 17 | 17 |
config.before :suite do |
| 18 | 18 |
Warden.test_mode! |
| 19 | 19 |
end |
+ 0
- 12
spec/helpers/capybara_poltergeist_screenshot.rb
@@ -1,12 +0,0 @@ |
||
| 1 |
-require 'launchy' |
|
| 2 |
- |
|
| 3 |
-module Capybara |
|
| 4 |
- module PoltergeistScreenshot |
|
| 5 |
- def screenshot_and_open_image(full: false) |
|
| 6 |
- timestamp = Time.now.strftime('%Y-%m-%d-%H-%M-%S')
|
|
| 7 |
- screenshot_path = "tmp/capybara/screenshot_#{timestamp}_#{SecureRandom.hex}.png"
|
|
| 8 |
- page.save_screenshot(screenshot_path, full: full) |
|
| 9 |
- Launchy.open screenshot_path |
|
| 10 |
- end |
|
| 11 |
- end |
|
| 12 |
-end |