app/models/agents/twitter_user_agent.rb

@@ -67,22 +67,27 @@ module Agents

                         options['expected_update_period_in_days'].present?
              

                         errors.add(:base, "username and expected_update_period_in_days are required")
              

                       end
              

                +
              

                +      if options[:include_retweets].present? &&
              

                +        !(!!options[:include_retweets] === true || !!options[:include_retweets] === false)
              

                +        errors.add(:base, "include_retweets must be a boolean (true/false)")
              

                +      end
              

                +
              

                +      if options[:starting_at].present?
              

                +        Time.parse(options[:starting_at]) rescue errors.add(:base, "Error parsing starting_at")
              

                +      end
              

                     end
              

                 
              

                     def starting_at
              

                       if options[:starting_at].present?
              

                -        Time.parse(options[:starting_at])
              

                +        Time.parse(options[:starting_at]) rescue created_at
              

                       else
              

                         created_at
              

                       end
              

                     end
              

                 
              

                     def include_retweets?
              

                -      if options[:include_retweets].present?
              

                -        !!options[:include_retweets]
              

                -      else
              

                -        true
              

                -      end
              

                +      options[:include_retweets] != false
              

                     end
              

                 
              

                     def check
              

spec/models/agents/twitter_user_agent_spec.rb

@@ -8,7 +8,7 @@ describe Agents::TwitterUserAgent do

                     @opts = {
              

                       :username => "tectonic",
              

                       :expected_update_period_in_days => "2",
              

                -      :starting_at => "Jan 01 00:00:01 +0000 2014",
              

                +      :starting_at => "Jan 01 00:00:01 +0000 2000",
              

                       :consumer_key => "---",
              

                       :consumer_secret => "---",
              

                       :oauth_token => "---",
              
@@ -26,4 +26,16 @@ describe Agents::TwitterUserAgent do

                     end
              

                   end
              

                 
              

                +  describe "#check with starting_at=future date" do
              

                +    it "should check for changes starting_at a future date, thus not find any" do
              

                +      opts = @opts.merge({ :starting_at => "Jan 01 00:00:01 +0000 2999", })
              

                +
              

                +      checker = Agents::TwitterUserAgent.new(:name => "tectonic", :options => opts)
              

                +      checker.user = users(:bob)
              

                +      checker.save!
              

                +
              

                +      lambda { checker.check }.should change { Event.count }.by(0)
              

                +    end
              

                +  end
              

                +
              

                 end